Re: Review Request 4: OPTICKS-1621:Display Session Explorer Tabs Simultaneously

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 4: OPTICKS-1621:Display Session Explorer Tabs Simultaneously

tclarke
Administrator
This is an automatically generated e-mail. To reply, visit: http://reviews.opticks.org/r/4/

branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.h (Diff revision 2)
25
class DOMNode;

This is in the xerces XML namespace. Either include the xml headers here or put the pre-declaration in the proper namespace. There are other examples in the code of this.


branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.h (Diff revision 2)
public:
105
   virtual bool fromXml(DOMNode* pDocument, unsigned int version);

DOMNode needs to be in the right namespace (use the xerces namespace macro)


branches/future/OPTICKS-1621/Code/application/Gui/TearableTabWidget.h (Diff revision 2)
16
//class DOMNode;

Remove this line


- Trevor Clarke


On January 26th, 2015, 4:10 p.m. UTC, Robert Goffena wrote:

Review request for Opticks Core Committers and Trevor Clarke.
By Robert Goffena.

Updated Jan. 26, 2015, 4:10 p.m.

Repository: Opticks

Description

OPTICKS-1621:Display Session Explorer Tabs Simultaneously

Diffs

  • branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.h (18761)
  • branches/future/OPTICKS-1621/Code/application/Desktop/SessionExplorerImp.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/Gui.vcxproj.filters (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabBar.cpp (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabWidget.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Interfaces/DockWindow.h (18761)
  • branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/Gui.vcxproj (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabBar.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabWidget.cpp (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/PlugInSamplerQt.vcxproj.filters (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugInLib/DockWindowShell.h (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugInLib/DockWindowShell.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/TearableTabsDemo.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/PlugInSamplerQt.vcxproj (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/TearableTabsDemo.cpp (PRE-CREATION)

View Diff


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opticks-devs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opticks-devs
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 4: OPTICKS-1621:Display Session Explorer Tabs Simultaneously

tclarke
Administrator
This is an automatically generated e-mail. To reply, visit: http://reviews.opticks.org/r/4/

branches/future/OPTICKS-1621/Code/application/Interfaces/DockWindow.h (Diff revision 2)
public:
184
   virtual void setWidgets(std::vector<std::pair<QWidget*, std::string>> widgets) = 0;

needs to be changed to > > in a number of places for linux build to succeed.


- Trevor Clarke


On January 26th, 2015, 4:10 p.m. UTC, Robert Goffena wrote:

Review request for Opticks Core Committers and Trevor Clarke.
By Robert Goffena.

Updated Jan. 26, 2015, 4:10 p.m.

Repository: Opticks

Description

OPTICKS-1621:Display Session Explorer Tabs Simultaneously

Diffs

  • branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.h (18761)
  • branches/future/OPTICKS-1621/Code/application/Desktop/SessionExplorerImp.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/Gui.vcxproj.filters (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabBar.cpp (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabWidget.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Interfaces/DockWindow.h (18761)
  • branches/future/OPTICKS-1621/Code/application/Desktop/DockWindowImp.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/Gui.vcxproj (18761)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabBar.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/Gui/TearableTabWidget.cpp (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/PlugInSamplerQt.vcxproj.filters (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugInLib/DockWindowShell.h (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugInLib/DockWindowShell.cpp (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/TearableTabsDemo.h (PRE-CREATION)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/PlugInSamplerQt.vcxproj (18761)
  • branches/future/OPTICKS-1621/Code/application/PlugIns/src/PlugInSamplerQt/TearableTabsDemo.cpp (PRE-CREATION)

View Diff


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opticks-devs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opticks-devs