Re: Review Request 1: OPTICKS-1626:Add Pseudo Full Screen Mode

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 1: OPTICKS-1626:Add Pseudo Full Screen Mode

tclarke
Administrator
This is an automatically generated e-mail. To reply, visit: http://reviews.opticks.org/r/1/

trunk/future/Code/application/Gui/ApplicationWindow.cpp (Diff revision 1)
3732
      for (auto iter = windows.begin(); iter != windows.end(); ++ iter)

Don't use "auto" as the gcc on RHEL 6.5 doesn't fully support c++11.


trunk/future/Code/application/Gui/ApplicationWindow.cpp (Diff revision 1)
3752
      for (auto iter = mToolbarDisplayStatus.begin(); iter != mToolbarDisplayStatus.end(); ++iter)

Don't use auto.


trunk/future/Code/application/Gui/ApplicationWindow.cpp (Diff revision 1)
3773
      for (auto iter = windows.begin(); iter != windows.end(); ++ iter)

Don't use auto


trunk/future/Code/application/Gui/ApplicationWindow.cpp (Diff revision 1)
3794
      for (auto iter = mDockWindowDisplayStatus.begin(); iter != mDockWindowDisplayStatus.end(); ++iter)

Don't use auto


trunk/future/Code/application/Gui/ApplicationWindow.cpp (Diff revision 1)
void ApplicationWindow::enableActions(bool bEnable)
5091
   mpFullScreenAction->setEnabled(true);

Should this be bEnable? If not, add a comment indicating why this is always true.


trunk/future/Code/application/Gui/Gui.vcxproj (Diff revision 1)
161
    <ClCompile Include="..\..\Build\Moc\Gui\moc_OptionsFullScreen.cpp" />

Use macros instead of hard coded path.


trunk/future/Code/application/Gui/Gui.vcxproj.filters (Diff revision 1)
905
    <ClCompile Include="..\..\Build\Moc\Gui\moc_OptionsFullScreen.cpp">

Macros instead of relative path


trunk/future/Code/application/Gui/OptionsFullScreen.cpp (Diff revision 1)
70
   VERIFYNR(NULL != pStayVisibleDockWindowNames);

This can be full if the setting hasn't been set yet. I believe you may just need to add an empty list to the 1-ApplicationDefaults.cfg Check these by deleteing your userprefs, starting opticks with verification messages enabled (the default in Debug builds), then open the Tools->Options. You'll see a verify on this line.


trunk/future/Code/application/Gui/OptionsFullScreen.cpp (Diff revision 1)
117
   VERIFYNR(NULL != pStayVisibleToolBarNames);

Same thing as above. This triggers when no user options exist.


- Trevor Clarke


On November 27th, 2014, 1:07 p.m. UTC, Robert Goffena wrote:

Review request for Opticks Core Committers and Trevor Clarke.
By Robert Goffena.

Updated Nov. 27, 2014, 1:07 p.m.

Repository: Opticks

Description

OPTICKS-1626:Add Pseudo Full Screen Mode

Diffs

  • trunk/future/Code/application/Gui/ApplicationWindow.cpp (18769)
  • trunk/future/Code/application/Gui/Gui.vcxproj.filters (18769)
  • trunk/future/Code/application/Gui/OptionsFullScreen.h (PRE-CREATION)
  • trunk/future/Code/application/Gui/OptionsFullScreen.cpp (PRE-CREATION)
  • trunk/future/Code/application/Gui/ApplicationWindow.h (18769)
  • trunk/future/Code/application/Gui/Gui.vcxproj (18769)
  • trunk/future/Code/application/PlugInManager/CoreModuleDescriptor.cpp (18769)

View Diff


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opticks-devs mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/opticks-devs
Loading...